Allow using vpaid-html5-client from a project that uses browserify #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ses browserify, since you can't browserify a browserified module (See browserify/browserify#1151) Adding the option below to package.json allows including the raw javascript, allowing the requiring module to handle the browserification. To include the module with require you should npm install vpaid-html5-client and then include it like this: var VPAIDHTML5Client = require('vpaid-html5-client/js/VPAIDHTML5Client.js');
Fetz
added a commit
that referenced
this pull request
Nov 24, 2015
Allow using vpaid-html5-client from a project that uses browserify
iq-dot
pushed a commit
to iq-dot/VPAIDHTML5Client
that referenced
this pull request
Jul 28, 2017
realised how play pause was actually working in video.js and adjusted styling accordingly (i.e. using ::before rather than background-image) speaker icon for volume bar styled progress bar copied to emulate telegraph style fullscreen button styled with telegraph styles, although not positioned correctly yet. hiding unnecessary controls styled volume slider with correct color and position (not sure how to completely emulate telegraph volume bar yet). Also added flex to position full screen button added bottom border to player and removed multiple playback speed options from App.jsx styling on time display done, replacing time remaining with current time / duration time display growing with flex to push full screen button to right edge volume controls always displaying added condition to apply telegraph styles only if telegraph is client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the module can't be used from within another project that uses browserify, since you can't browserify a browserified module (See browserify/browserify#1151)
Adding the option below to package.json allows including the raw javascript, allowing the requiring module to handle the browserification.
To include the module with require you should
npm install vpaid-html5-client
and then include it like this:
var VPAIDHTML5Client = require('vpaid-html5-client/js/VPAIDHTML5Client.js');