protect onLoad event from getting invalid event data with try catch #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iq-dot
pushed a commit
to iq-dot/VPAIDHTML5Client
that referenced
this pull request
Jul 28, 2017
* copied across imports and render function into new file Player.jsx from App.jsx. May not all be needed, but will trim as I go * moved videoJSInit into player.js and moved event listeners to props * moved all state from player.jsx to app.jsx * reverting changes to bring videojsinit into player.jsx. I think this was the wrong approach, but can still go back and grab it if needs be * moved most of componentDidMount into Player.jsx, along with static function getVideos * passing necessary stuff for Player via props * App.js accessing this.videoNode through this.playerNode * moved handleScroll event listeners into Player.jsx, and passed function via props * some further adjustments to the handleScroll event to get it working properly across App.jsx and Player.jsx * moved handleScroll and related stuff to Player.jsx, passing necessary state via props * binding functions passed as props in constructor | passing player as parameter back to functions in App.jsx * removing unneccessary imports from Player.jsx * changed Player to React.PureComponent | moved getVideos back to App.jsx and passing result as props * Passing videoJsOptions to Player through props. The options are stored on the App state * moved logic to dispose player from componentWillUnmount in App.jsx to Player.jsx * have handleScroll working, but not sure I'm following best practice here * readded console.log of CLIENT, seeing as I have componentDidMount in App.jsx now * moved plugins across to Player and passed in stuff via props * believe I've done everything to get plugins() working correctly * moved overlay and videoJsInit functions from App.js to Player.js * updated overlay and videoJsInit to use props and state correctly * further adjustments to get functions working * minor changes. Made Modernizr a prop, and made url a const in render to be passed to App.getVideos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.