Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support to run parts of the tool #6

Merged
merged 1 commit into from
Feb 10, 2019
Merged

Added support to run parts of the tool #6

merged 1 commit into from
Feb 10, 2019

Conversation

melchor629
Copy link
Member

@melchor629 melchor629 commented Feb 10, 2019 •
edited
Loading 

$ python -m mdbackup --help
usage: __main__.py [-h] [-c CONFIG] [--backup-only] [--upload-current-only]
                   [--cleanup-only]

Small but customizable utility to create backups and store them in cloud
storage providers

optional arguments:
  -h, --help            show this help message and exit
  -c CONFIG, --config CONFIG
                        Path to configuration (default: config/config.json)
  --backup-only         Only does the backup actions
  --upload-current-only
                        Only uploads the last backup
  --cleanup-only        Only does the backup cleanup

main code was moved to a function, but no modification was done in the original code.

@melchor629 melchor629 added the enhancement New feature or request label Feb 10, 2019
@melchor629 melchor629 self-assigned this Feb 10, 2019
@melchor629 melchor629 requested review from Alkesst and amgxv February 10, 2019 19:30
melchor629
melchor629 commented Feb 10, 2019
View reviewed changes
mdbackup/backup.py
@@ -30,7 +30,7 @@ def generate_backup_path(backups_folder: Path) -> Path:
Creates a path with the folder (named with the right structure)
that will be used as backup folder in this run.
"""
now = datetime.now()
now = datetime.utcnow()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to UTC date instead of current time. It is better to use UTC :)

Alkesst
Alkesst approved these changes Feb 10, 2019
View reviewed changes
Copy link
Member

@Alkesst Alkesst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without having any idea of how it is the concrete behaviour of the system, everything seems okey. 😸

@melchor629 melchor629 merged commit 92c99ac into master Feb 10, 2019
@melchor629 melchor629 deleted the split-parts-args branch February 10, 2019 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alkesst Alkesst Alkesst approved these changes

@amgxv amgxv Awaiting requested review from amgxv

Assignees

@melchor629 melchor629

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@melchor629 @Alkesst