Fix aliases with commas in them. #179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…liases with commas being incorrectly split.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the fact that aliases with commas in them that are specified as a list will incorrectly be split by those commas.
For example:
Will appear as two separate items,
December 19th, and2023. This is not in alignment with how Obsidian handles aliases in lists normally. To fix this, I've implemented a character sequence thatoption-multilists are delimited by instead of a comma. It's just two random emoji, similar to other parts of the codebase. This allows Make.md to properly split the aliases.I haven't done much testing for other parts of the codebase using
option-multi, but at a glance, it all seems to be working. I hope this helps, and can be merged!