Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

Added Time Complexity and remove single comment into multi comment #135

Merged
merged 2 commits into from
Apr 5, 2021

Conversation

UG-SEP
Copy link
Member

@UG-SEP UG-SEP commented Apr 4, 2021

hey,
I have done some changes in Permutation of string.c file please review it

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Thank you for opening a Pull Request, Welcome to DSA

We will review everything and get back to you, Please checkout our CONTRIBUTING RULES and CODE OF CONDUCT, Thanks 😃

@ming-tsai ming-tsai requested a review from Arsenic-ATG April 4, 2021 19:29
@ming-tsai ming-tsai added the C languages used is C label Apr 4, 2021
@Arsenic-ATG Arsenic-ATG added the enhancement New feature or request label Apr 5, 2021
Arsenic-ATG
Arsenic-ATG previously approved these changes Apr 5, 2021
strings/c-or-cpp/Permutation-of-String.c Show resolved Hide resolved
strings/c-or-cpp/Permutation-of-String.c Show resolved Hide resolved
strings/c-or-cpp/Permutation-of-String.c Show resolved Hide resolved
@UG-SEP
Copy link
Member Author

UG-SEP commented Apr 5, 2021

@Arsenic-ATG

@UG-SEP UG-SEP dismissed Arsenic-ATG’s stale review via db9b385 10 minutes ago
what happen i haven't done anything just added new line but how It dismissed you stale review via db9b385

@Arsenic-ATG
Copy link
Member

Arsenic-ATG commented Apr 5, 2021

what happen i haven't done anything just added new line but how It dismissed you stale review via db9b385

yes, it's not your fault

It is GitHub's bug feature where it dismisses all the code review on the branch whenever a new commit is added to it ( you can see this for more info (isaacs/github#1157) )

not worries. I will approve it again.

@UG-SEP
Copy link
Member Author

UG-SEP commented Apr 5, 2021

what a bug😁😁😂

@ming-tsai
Copy link
Member

Great jobs @UG-SEP

@ming-tsai ming-tsai merged commit 616e931 into MakeContributions:main Apr 5, 2021
@UG-SEP UG-SEP deleted the UG branch April 7, 2021 05:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C languages used is C enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants