-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin node and npm versions #119
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Seems like vercel is trying to use version 18. We should update vercel too to make sure the same version is used locally and on hosted envs |
63c8f1b
to
26ed773
Compare
Actually seems like vercel only supports pinning major version https://vercel.com/docs/functions/runtimes/node-js/node-js-versions#version-overrides-in-package.json. I got the warning on this build: I don't like that we can't control the exact version but I'll guess we will have to work with it. I'll then update the pr to only specify the major version too |
26ed773
to
f94dae5
Compare
@@ -2,6 +2,10 @@ | |||
"name": "quick-cashu", | |||
"version": "0.1.0", | |||
"private": true, | |||
"engines": { | |||
"node": "20.x", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this now means that vercel will always build with latest node version 20 and locally you will be forced to use any version 20. however if you use nvm it will still use 20.18.0 as specified in nvmrc. that way at least dev locally can be in sync
yea this is fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks!
This is to make sure all devs are using the same node and npm versions. Strict setting will make the npm command with an incorrect version fail with the appropriate message