Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_ticks(ticks, identity, Makie.automatic, limits...) results in unintended results #4441

Open
2 tasks
thomvet opened this issue Oct 2, 2024 · 0 comments · May be fixed by #4442
Open
2 tasks

get_ticks(ticks, identity, Makie.automatic, limits...) results in unintended results #4441

thomvet opened this issue Oct 2, 2024 · 0 comments · May be fixed by #4442
Labels
Axis related to `Axis()` objects bug Makie Backend independent issues (Makie core)

Comments

@thomvet
Copy link
Contributor

thomvet commented Oct 2, 2024 •
edited by t-bltg
Loading

  • what version of Makie are you running? (]st -m Makie) - running v0.21.12
  • can you reproduce the bug with a fresh environment ? (]activate --temp; add Makie) - yes

Minimal reproducing example:

using Makie
ticks = 0.0:0.2:1.0
limits = (0.0, 0.6)
Makie.get_ticks(ticks, identity, Makie.automatic, limits...)

Result:
([0.0, 0.2, 0.4, 0.6, 0.8, 1.0], ["0.0", "0.2", "0.4", "0.6", "0.8", "1.0"])

Expected behavior:
I would have expected that I do not get ticks returned at 0.8 and 1.0, because I have given in the limits.

Probable source of bug:

Makie.jl/src/makielayout/lineaxis.jl

Line 631 in 59456d3

get_tickvalues(tickvalues, vmin, vmax) = convert(Vector{Float64}, tickvalues)

This function ignores vmin and vmax - I would have expected that a filter gets applied.
@thomvet thomvet added the bug label Oct 2, 2024
thomvet added a commit to thomvet/Makie.jl that referenced this issue Oct 2, 2024
@thomvet
fix: reintroduce vmin, vmax into get_ticks; addresses MakieOrg#4441
22a32db
@thomvet thomvet linked a pull request Oct 2, 2024 that will close this issue
Open
@t-bltg t-bltg changed the title get_ticks(ticks, identity, Makie.automatic, limits...) results in unintended results get_ticks(ticks, identity, Makie.automatic, limits...) results in unintended results Oct 6, 2024
@ffreyer ffreyer added Makie Backend independent issues (Makie core) Axis related to `Axis()` objects labels Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Axis related to `Axis()` objects bug Makie Backend independent issues (Makie core)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: reintroduce vmin, vmax into get_ticks; addresses #4441 thomvet/Makie.jl
2 participants
@ffreyer @thomvet