Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local serve in ReferenceUpdater #4444

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Oct 3, 2024

#4398 did not update things correctly for the local option and also has some problems when called with windows-styled paths

@MakieBot
Copy link
Collaborator

MakieBot commented Oct 3, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 4.89s (4.79, 5.03) 0.09+- 119.02ms (111.83, 136.50) 8.71+- 440.56ms (428.29, 454.10) 11.12+- 9.14ms (8.48, 10.20) 0.79+- 26.72ms (26.37, 27.04) 0.26+-
master 4.93s (4.85, 5.04) 0.06+- 119.69ms (114.64, 127.01) 4.38+- 443.51ms (425.47, 456.51) 10.94+- 9.38ms (8.45, 10.60) 0.90+- 26.67ms (26.40, 26.80) 0.13+-
evaluation 1.01x invariant, -0.04s (-0.44d, 0.43p, 0.08std) 1.01x invariant, -0.67ms (-0.10d, 0.86p, 6.54std) 1.01x invariant, -2.95ms (-0.27d, 0.63p, 11.03std) 1.03x invariant, -0.24ms (-0.29d, 0.60p, 0.85std) 1.00x invariant, 0.05ms (0.24d, 0.66p, 0.20std)
CairoMakie 4.62s (4.45, 4.71) 0.09+- 115.28ms (110.51, 122.36) 4.39+- 174.46ms (166.77, 183.41) 5.55+- 9.45ms (9.27, 9.78) 0.18+- 1.17ms (1.15, 1.27) 0.04+-
master 4.53s (4.43, 4.65) 0.08+- 113.41ms (108.82, 124.20) 5.31+- 171.24ms (165.57, 178.17) 4.35+- 8.96ms (8.88, 9.30) 0.15+- 1.14ms (1.13, 1.15) 0.01+-
evaluation 0.98x invariant, 0.09s (1.03d, 0.08p, 0.09std) 0.98x invariant, 1.87ms (0.38d, 0.49p, 4.85std) 0.98x invariant, 3.22ms (0.65d, 0.25p, 4.95std) 0.95x slower❌, 0.5ms (2.96d, 0.00p, 0.17std) 0.97x invariant, 0.03ms (1.01d, 0.11p, 0.02std)
WGLMakie 5.33s (5.23, 5.52) 0.11+- 115.39ms (110.39, 130.41) 7.36+- 5.04s (4.98, 5.15) 0.06+- 12.09ms (11.45, 14.00) 0.87+- 117.93ms (115.45, 119.76) 1.78+-
master 5.29s (5.17, 5.40) 0.07+- 113.29ms (109.07, 120.05) 4.30+- 5.05s (4.94, 5.26) 0.12+- 11.70ms (11.38, 12.32) 0.31+- 118.09ms (111.14, 121.94) 3.63+-
evaluation 0.99x invariant, 0.04s (0.43d, 0.44p, 0.09std) 0.98x invariant, 2.1ms (0.35d, 0.53p, 5.83std) 1.00x invariant, -0.01s (-0.05d, 0.92p, 0.09std) 0.97x invariant, 0.39ms (0.60d, 0.30p, 0.59std) 1.00x invariant, -0.16ms (-0.06d, 0.92p, 2.70std)

@ffreyer ffreyer merged commit 7737b97 into master Oct 3, 2024
18 checks passed
@ffreyer ffreyer deleted the ff/fix-local-ReferenceUpdater branch October 3, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips changelog enforcer
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants