Fix uses of trim as callback

trim function cannot be used as callback argument of array_walk since the second argument of the callback (array index) conflicts with the second argument of trim (characters to trim) dealing in unexpected behaviors.
Maks3w · Jan 13, 2014 · 6bec874 · 6bec874
1 parent 723a50a
commit 6bec874
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/library/Zend/Http/Header/ContentType.php b/library/Zend/Http/Header/ContentType.php
@@ -248,7 +248,13 @@ protected function assembleValue()
     protected function splitMediaTypesFromString($criteria)
     {
         $mediaTypes = explode(',', $criteria);
-        array_walk($mediaTypes, 'trim');
+        array_walk(
+            $mediaTypes,
+            function (&$value) {
+                $value = trim($value);
+            }
+        );
+
         return $mediaTypes;
     }
 

diff --git a/library/Zend/Mail/Header/AbstractAddressList.php b/library/Zend/Mail/Header/AbstractAddressList.php
@@ -58,7 +58,12 @@ public static function fromString($headerLine)
         // split value on ","
         $fieldValue = str_replace(Headers::FOLDING, ' ', $fieldValue);
         $values     = explode(',', $fieldValue);
-        array_walk($values, 'trim');
+        array_walk(
+            $values,
+            function (&$value) {
+                $value = trim($value);
+            }
+        );
 
         $addressList = $header->getAddressList();
         foreach ($values as $address) {