Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking change | esp8266 sdk version >= 3.0.1 | I2S.h #485

Closed
coelner opened this issue Jun 14, 2021 · 4 comments
Closed

breaking change | esp8266 sdk version >= 3.0.1 | I2S.h #485

coelner opened this issue Jun 14, 2021 · 4 comments
Labels
external Cause is external to this library (does not mean a work around for it is a valid solution) pending Pending new release; already merged but not released in a version

Comments

@coelner
Copy link

coelner commented Jun 14, 2021

With the esp8266 sdk version 3.0.1 onwards: esp8266/Arduino#8108
will break this line:

NeoPixelBus/src/internal/NeoEsp8266DmaMethod.h

Line 42 in 2ff885c

#include "i2s.h"

@Makuna
Copy link
Owner

Makuna commented Jun 14, 2021

#486

@Makuna Makuna added external Cause is external to this library (does not mean a work around for it is a valid solution) pending Pending new release; already merged but not released in a version labels Jun 14, 2021
@akarnani
Copy link

akarnani commented Jul 1, 2021

Would it be possible to cut a release with the above pull request included? It would be nice to be able to pull in these changes with the library manager.

@coelner
Copy link
Author

coelner commented Jul 1, 2021

The release 3.0.1 is officially available: https://github.com/esp8266/Arduino/releases/tag/3.0.1

I do not know any method to determine which version is installed and select through a precomiler flag the right code snippet.

@Makuna
Copy link
Owner

Makuna commented Jul 1, 2021

v2.6.5

@Makuna Makuna closed this as completed Jul 1, 2021
tali added a commit to tali/Wortuhr that referenced this issue Jul 28, 2021
@tali
Update NeoPixelBus for compatibility with SDK 3.0.1
5639cb3 
Older Versions of NeoPixelBus don't compile with newer ESP8266 SDK versions.
(Makuna/NeoPixelBus#485)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
external Cause is external to this library (does not mean a work around for it is a valid solution) pending Pending new release; already merged but not released in a version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akarnani @Makuna @coelner