Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Greek localization and updated some plugins/libs versions #229

Merged
merged 8 commits into from
Aug 24, 2024
Merged

Add Greek localization and updated some plugins/libs versions #229

merged 8 commits into from
Aug 24, 2024

Conversation

Dimitrysaf
Copy link

Plugins updated:

  1. android Gradle Plugin 8.3.2 >> 8.5.1
  2. guava 32.1.3 >> 33.2.1
  3. coroutines guava 1.7.3 >> 1.8.1
  4. navigation 2.6.0 >> 2.7.7
  5. compose foundation compose >> 1.6.8
  6. accompanist swiperefresh 0.28.0 >> 0.34.0
  7. shimmer 1.0.3 >> 1.3.0
  8. apache lang3 3.12.0 >> 3.14.0
  9. opencc4j 1.7.2 >> 1.8.1
  10. timber 4.7.1 >> 5.0.1
  11. distribution gradle 8.4 >> 8.7

Note: you can Ignore the updated version if you wish, I simply updated them to correctly start in Android Studio with any emulator. Also tested the app on my phone! Worked obviously.

Languages added:

Greek (Greece)
Note: Language tested and worked perfectly without any unfitted (i.e. the "..." at the end of a) line.

@Malopieds
Copy link
Owner

Hi, thanks for the PR, I'm away from a keyboard for some time. I will skip the updated versions, it often need a clear understanding of what has changed and can break some behavior easily. I'll do it when I have a bit more time !

@8cAyqpVKio
Copy link

8cAyqpVKio commented Jul 15, 2024

Hi.
I agree that libraries should be upgraded carefully. In particular, accompanist's swiperefresh has already been integrated into androidx.material3 and needs to be refactored according to the migration guide provided by accompanist.
https://google.github.io/accompanist/swiperefresh/

@Malopieds Malopieds merged commit 41ee85c into Malopieds:dev Aug 24, 2024
Malopieds added a commit that referenced this pull request Aug 24, 2024
* Create strings.xml

Greek language added

* Update strings.xml

Fixed a plural issue

* Update strings.xml

plural change

* Search online >> Search
Didn't fit

* Update "..." to "(insert smaller dots here)"

---------

Co-authored-by: Malopieds <74783202+Malopieds@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants