Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify queue multiselect look with playlist screen (reopenend) #237

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

thornySoap
Copy link

There is already a multiselect look in the playlist screen, so the provisionally looking check boxes in the queue don't seem to be necessary in my opinion.
This is what I thought would work well (The screen record also includes the commits from #233):

demo.mp4

I'm open for suggestions and improvements!

Copy link

@mostafaalagamy mostafaalagamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a issue when moving the queue list items to arrange the songs by dragging.

Screenrecorder-2024-07-31-01-45-14-446.mp4

@thornySoap
Copy link
Author

Thanks for testing! I'm not at my PC for some time, but when I am I will definetly look into that.

@thornySoap
Copy link
Author

But generally I'm not quite sure if the design is well made or suitable for the queue.
I really just copied it from the playlist screen.

@thornySoap thornySoap marked this pull request as draft August 9, 2024 17:17
@Malopieds Malopieds merged commit b471bc8 into Malopieds:dev Aug 9, 2024
@Malopieds
Copy link
Owner

This one was messy but I think it's a good implementation !

I just changed some things:

  • the icon of select
  • fixed the reorder issue
  • fix some padding that seemed too much (It may have been from the merge)

Other than that, a big thank you for this !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants