Update GitHub actions for consistency #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
force-pushed
the
github_actions
branch
8 times, most recently
from
a908e93
to
ca6985d
Compare
- Fix tests - Make the services, test names, etc consistent with other ManageIQ repos - Fix CodeClimate
Fryguy
force-pushed
the
github_actions
branch
from
ca6985d
to
3f182c1
Compare
Fryguy
commented
Jan 10, 2022
| - "60" | ||
| services: | ||
| postgres: | ||
| image: postgres:13 |
There was a problem hiding this comment.
I was going to switch this over to manageiq/postgresql:10 for consistency, but for some reason I was getting unhealthy containers. For now, this is fine.
Fryguy
commented
Jan 10, 2022
| @@ -21,3 +21,4 @@ mysql2: | |||
| <<: *common | |||
| adapter: mysql2 | |||
| username: root | |||
| host: 127.0.0.1 | |||
There was a problem hiding this comment.
The MySQL tests would not work without this because localhost tells the mysql client to use a local socket which won't work in github actions.
|
@kbrock It looks like an add and a delete, because I renamed the file from ci.yml to ci.yaml for consistency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repos
@kbrock Please review.