pass all parameters to preloader children #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit kbrock@46ea0af with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
hmm, that's odd... it seems like it should break all the time if that was the case |
|
We tend to passing nothing or a list of records into the preloader. Only the metrics collection will have an issue as one place it does And that spot we will need to change by passing in the scope. ref: https://github.com/kbrock/manageiq/blob/master/app/models/metric/rollup.rb#L275 |
|
LGTM, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes all the parameters from the preloader into the new preloader.
This was causing a problem in manageiq preloader specs.
Unfortunately, I do not fully understand these parameters, I just know we want to pass them all.
And I'm no longer able to reproduce the issue.
But not passing these along seems like a mistake