Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using actions instead of travis ci #98

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Jan 10, 2022

This is cargo culted from ancestry.
But since I had spent a lot of time on building that implementation that I didn't feel too guilty.

If you note, all databases are running as a single job. reasons:

  • the container setup times are much bigger than the runtime. Condensing them got all jobs running much quicker.
  • failure in one database tended to be a failure in other databases. The exact database that caused the failure was not much of a concern
  • At first, I had a gem file per database/rails version. Consolidating a gem per rails version and ignoring the database turned out to be a much better decision. So applying that logic to the build system seemed to also make sense.

@kbrock kbrock force-pushed the action branch 2 times, most recently from c7d5f5f to 78c9033 Compare January 10, 2022 17:50
@chessbyte
Copy link
Member

You probably also want to change the link to Travis in https://github.com/ManageIQ/activerecord-virtual_attributes/blob/master/README.md

@Fryguy
Copy link
Member

Fryguy commented Jan 10, 2022

I can merge for now once it goes green, but I'll likely update to match the ones we have elsewhere, so that we have consistency (and also because eventually I want to have a centralized github workflow).

@Fryguy Fryguy merged commit 81890d2 into ManageIQ:master Jan 10, 2022
@Fryguy Fryguy added test Test Only and removed developer labels Jan 10, 2022
@kbrock kbrock deleted the action branch January 10, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Test Only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants