Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove sudo from travis yaml #52

Merged
merged 1 commit into from
Oct 16, 2020
Merged

remove sudo from travis yaml #52

merged 1 commit into from
Oct 16, 2020

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Oct 16, 2020

we can remove sudo:false per https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration: If you currently specify sudo: false in your .travis.yml, we recommend removing that configuration soon.

@miq-bot add_label cleanup
@miq-bot assign @kbrock

@miq-bot
Copy link
Member

miq-bot commented Oct 16, 2020

@d-m-u 'kbrock' is an invalid assignee, ignoring...

@coveralls
Copy link

coveralls commented Oct 16, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 70b0901 on d-m-u:patch-1 into f5538f6 on ManageIQ:master.

@d-m-u
remove sudo from travis yaml
70b0901 
we can remove sudo:false per https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration: `If you currently specify sudo: false in your .travis.yml, we recommend removing that configuration soon.`
@miq-bot
Copy link
Member

miq-bot commented Oct 16, 2020

Checked commit d-m-u@70b0901 with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@kbrock
Copy link
Member

kbrock commented Oct 16, 2020

👍 I can't merge though.
easy 🍒 for @Fryguy or @jrafanie

@Fryguy Fryguy merged commit 2a66fd9 into ManageIQ:master Oct 16, 2020
@d-m-u d-m-u deleted the patch-1 branch October 16, 2020 18:24
Fryguy added a commit that referenced this pull request Nov 1, 2023
@Fryguy
Release v1.6.0
0e59251 
Added:
- Add `CommandResult#pid` [#49]
- Add `AwesomeSpawn.run_detached` [#52]
- Add `SpecHelper.disable_spawning` helper method [#66]
- Add support for Ruby versions 2.5 to 3.2 [#56, #62, #70]

Removed:
- Remove support for old Ruby versions 2.0 to 2.4 [#56]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@d-m-u @miq-bot @coveralls @kbrock @Fryguy