Remove remnants of bundler 1.x support #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
force-pushed
the
remove_1_17_completely
branch
5 times, most recently
from
ad51447
to
f233f2e
Compare
|
@Fryguy the versions of bundler that we are supporting are arbitrary - do you want to support 2.1 and 2.2? seems like it would clean up the code |
This commit fixes a bug based on the partial matching to detect the bundler version. Previously a simple substring comparison was done, but then "2.1" would match "2.2.15", which is wrong.
If the code was previously bundled with 1.17, the tests will try to run with 1.17 locally. This change ensures that locally it runs with the latest installed bundler. Additionally, one spec was written with multiple versions in mind, which we can now drop.
Fryguy
force-pushed
the
remove_1_17_completely
branch
from
f233f2e
to
d202155
Compare
It's a good question - I thought you chose the version numbers based on what the "supported" versions of bundler/ruby/rubygems are. If 2.0 is still supported, I'd rather keep it for now. |
agrare
added a commit
that referenced
this pull request
Jan 9, 2024
Fixed * Remove remnants of bundler 1.x support (#20) * Fix detection of bundler version (#21) * Fix spec issues after release of bundler 2.4.17 (#32) Added * Switch to GitHub Actions (#25) * Add bundler 2.4 to the test matrix (#28) * Add Ruby 3.1 and 3.2 to test matrix (#29) * Allow user to specify a PATH to search for gem overrides (#34)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the code was previously bundled with 1.17, the tests will try to run
with 1.17 locally. This change ensures that locally it runs with the
latest installed bundler.
Additionally, one spec was written with multiple versions in mind, which
we can now drop.
Build on top of #21
@kbrock Please review.