-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to GitHub Actions #27
Conversation
Some comments on commit Fryguy@de06f58 spec/spec_helper.rb
|
Checked commit Fryguy@de06f58 with ruby 2.6.7, rubocop 1.19.1, haml-lint 0.35.0, and yamllint **
lib/ffi-vix_disk_lib/api.rb
spec/spec_helper.rb |
@agrare This is ready to go. Thanks for the help. I did it slightly different from you, by building a bin/setup file to mirror how we set up other repos, and also this way you can run it locally. Also, I clarified some of the Mac specific stuff. |
@@ -1,6 +1,15 @@ | |||
ENV["LD_LIBRARY_PATH"] ||= File.expand_path("ext", __dir__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this line was here for the Mac, but on newer Mac versions, it doesn't do anything anyway because of the SIP stuff.
Even so, I expected this to work on Linux, and I have no idea why you need to pass LD_LIBRARY_PATH manually. I guess that's something we can solve another day.
CI: https://github.com/Fryguy/ffi-vix_disk_lib/actions?query=branch%3Agithub_actions