Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to GitHub Actions #27

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Feb 15, 2022

@miq-bot miq-bot added the wip label Feb 16, 2022
@Fryguy Fryguy changed the title [WIP] Switch to GitHub Actions Switch to GitHub Actions Mar 31, 2022
@miq-bot miq-bot removed the wip label Mar 31, 2022
@miq-bot
Copy link
Member

miq-bot commented Mar 31, 2022

Some comments on commit Fryguy@de06f58

spec/spec_helper.rb

  • ⚠️ - 11 - Detected puts. Remove all debugging statements.
  • ⚠️ - 12 - Detected puts. Remove all debugging statements.

@miq-bot
Copy link
Member

miq-bot commented Mar 31, 2022

Checked commit Fryguy@de06f58 with ruby 2.6.7, rubocop 1.19.1, haml-lint 0.35.0, and yamllint
4 files checked, 4 offenses detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

lib/ffi-vix_disk_lib/api.rb

  • ❗ - Line 27, Col 10 - Performance/StringInclude - Use String#include? instead of a regex match with literal-only pattern.

spec/spec_helper.rb

  • ❗ - Line 8, Col 61 - Performance/RegexpMatch - Use match? instead of =~ when MatchData is not used.
  • ❗ - Line 8, Col 61 - Performance/StringInclude - Use String#include? instead of a regex match with literal-only pattern.

@Fryguy
Copy link
Member Author

Fryguy commented Mar 31, 2022

@agrare This is ready to go. Thanks for the help. I did it slightly different from you, by building a bin/setup file to mirror how we set up other repos, and also this way you can run it locally.

Also, I clarified some of the Mac specific stuff.

@@ -1,6 +1,15 @@
ENV["LD_LIBRARY_PATH"] ||= File.expand_path("ext", __dir__)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line was here for the Mac, but on newer Mac versions, it doesn't do anything anyway because of the SIP stuff.

Even so, I expected this to work on Linux, and I have no idea why you need to pass LD_LIBRARY_PATH manually. I guess that's something we can solve another day.

@agrare agrare merged commit 1151d45 into ManageIQ:master Apr 1, 2022
agrare added a commit that referenced this pull request Dec 21, 2022
Added:
- Add 8.0.0, 7.0.3, and 7.0.2 VDDK versions (#29)

Removed:
- Remove old unsupported VDDK versions up to 6.0 (#23)

Changed:
- Switch to GitHub Actions (#27)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants