Allow Rails 6.1 #103
Allow Rails 6.1 #103
Conversation
Just because this does deal with Active Record persistence so directly I'd like to run this through with cross-repo actually using rails 6.1, that way we can fix any issues in this PR |
I'm currently trying this out with rails 6.1 locally with a manual cross repo run. |
In the event you're running several in a batch, it's nice to report on what we're doing and not rely on ENV variables as some could be set via command line. The output looks something like this: ``` Starting cross repo for: test repo: ManageIQ/manageiq-providers-lenovo core repo: ManageIQ/manageiq#21652 gem repo: ManageIQ/inventory_refresh#103 Fetching https://github.com/ManageIQ/manageiq-providers-lenovo/tarball/dfeb7c99963eac29e9eb9f8f2f78ba2c9c3ee866 ```
agrare
force-pushed
the
allow_rails_6_1
branch
2 times, most recently
from
eaa9096
to
bcea63f
Compare
|
NOTE I've added rails 6.1 into the test matrix here |
Gemfile
Outdated
| @@ -14,4 +14,6 @@ when "5.2" | |||
| gem "activerecord", "~>5.2.6" | |||
| when "6.0" | |||
| gem "activerecord", "~>6.0.4" | |||
| when "6.1" | |||
| gem "activesupport", "~>6.1.4" | |||
There was a problem hiding this comment.
| gem "activesupport", "~>6.1.4" | |
| gem "activerecord", "~>6.1.4" |
There was a problem hiding this comment.
I think this repo actually uses both activerecord and activesupport, but only declares activerecord as a dependency...it probably should do both, and then also have both here as well.
agrare
force-pushed
the
allow_rails_6_1
branch
from
bcea63f
to
3a9b410
Compare
|
Checked commit agrare@3a9b410 with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint |
No description provided.