Merge pull request #315 from zeari/standard_err

catch standard error when watch stream finished
ManageIQ · Apr 11, 2018 · 359e8c1 · 359e8c1
2 parents ab99898 + fb7cb73
commit 359e8c1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/kubeclient/watch_stream.rb b/lib/kubeclient/watch_stream.rb
@@ -27,7 +27,7 @@ def each
             yield @formatter.call(line.chomp)
           end
         end
-      rescue IOError, Errno::EBADF
+      rescue StandardError
         raise unless @finished
       end
 

diff --git a/test/test_watch.rb b/test/test_watch.rb
@@ -132,10 +132,10 @@ def test_watch_with_finish_and_ebadf
     client = Kubeclient::Client.new(api_host, 'v1')
     watcher = client.watch_events
 
-    # explodes when Errno::EBADF is not caught
+    # explodes when StandardError is not caught
     watcher.each do
       watcher.finish
-      raise Errno::EBADF
+      raise StandardError
     end
 
     assert_requested(:get, "#{api_host}/v1/watch/events", times: 1)