Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated outdated dependencies #253

Merged
merged 1 commit into from
Jul 4, 2017
Merged

Conversation

Abdulwahaab710
Copy link
Contributor

In this PR I have updated the following outdated dependencies:

  • http
  • rake
  • recursive-open-struct
  • rubocop
  • webmock

@abonas
Copy link
Member

abonas commented Jun 14, 2017

hi, @Abdulwahaab710 .
please squash your commits, they have a similar name, and they have the same purpose.
also, travis is failing, please check its error messages. mostly I believe it's due to version bump of rubocop and the fix of this.

@Abdulwahaab710
Copy link
Contributor Author

Done :)

@simon3z
Copy link
Collaborator

simon3z commented Jun 14, 2017

@moolitayer can you review? (mostly for new dependencies versions implications)

@cben
Copy link
Collaborator

cben commented Jun 15, 2017

@moolitayer
Copy link
Collaborator

I hope they'll bump to at least 1.1.0 when it actually breaks ruby 2.0...

I doubt if they will even notice when that happens...

We probably want to enjoy @jrafanie's aetherknight/recursive-open-struct#52 with all the performance work going around, so I would consider dropping support of ruby 2.0 & 2.1 and bumping kubeclient's version. I'm not sure how/if that is problematic to users.

@kirs @grosser @albertrdixon care to comment on dropping ruby 2.0, 2.1 support ?

@grosser
Copy link
Contributor

grosser commented Jun 15, 2017

everything up to 2.1 is unsupported https://www.ruby-lang.org/en/news/2017/04/01/support-of-ruby-2-1-has-ended/ so I'm in favor of getting rid of it ... make the new gem have a require_ruby_version and it should not break for people stuck on older versions ...

@jrafanie
Copy link
Member

We probably want to enjoy @jrafanie's aetherknight/recursive-open-struct#52 with all the performance work going around,

@moolitayer I doubt that would help most use cases... I would think you would need an enormous recursive structure to see much difference. I could be wrong though.

I'm all for dropping unsupported rubies in a non-patch release 👍

@grosser
Copy link
Contributor

grosser commented Jun 15, 2017 via email

@kirs
Copy link
Contributor

kirs commented Jun 16, 2017

👍 for dropping anything < 2.1

@simon3z
Copy link
Collaborator

simon3z commented Jun 21, 2017

@Abdulwahaab710 @grosser @moolitayer @jrafanie we may want to change the .travis.yml as well at some point (now is running against 2.0 and 2.1 as well).

@simon3z
Copy link
Collaborator

simon3z commented Jun 21, 2017

@Abdulwahaab710 if you squash your 2 commits in 1 I think we're good to merge.

Updated outdated dependencies

fixing style for rubocop

droping support for ruby 2.0 and 2.1
@@ -1,7 +1,5 @@
language: ruby
rvm:
- "2.0"
- "2.1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simon3z I have removed rvm 2.0 and rvm 2.1

@cben
Copy link
Collaborator

cben commented Jan 22, 2018

We forgot to update required_ruby_version in gemspec, it's still 2.0.0 but we now have non-2.0 syntax.

@moolitayer moolitayer mentioned this pull request Jan 23, 2018
cben pushed a commit to cben/kubeclient that referenced this pull request Jan 25, 2018
Partially cherry-picked from commit d774ff9
+ picked style fixes
+ picked rubocop bump to 0.49.1 - affects default PercentLiteralDelimiters (rubocop/rubocop#4231)
- kept other dependencies untouched
- kept ruby 2.0, 2.1
cben pushed a commit to cben/kubeclient that referenced this pull request Jan 25, 2018
Partially cherry-picked from commit d774ff9
+ picked style fixes
+ picked rubocop bump to 0.49.1 - affects default PercentLiteralDelimiters (rubocop/rubocop#4231)
- kept other dependencies untouched
- kept ruby 2.0, 2.1
cben added a commit to cben/kubeclient that referenced this pull request Jan 25, 2018
Backporting ManageIQ#223 bumped to rubocop with different defaults.
These rubocop errors are fixed on master by ManageIQ#253 and ManageIQ#269
but we didn't backport those.
cben added a commit to cben/kubeclient that referenced this pull request Jan 25, 2018
Backporting ManageIQ#223 bumped to rubocop with different defaults.
These rubocop errors are fixed on master by ManageIQ#253 and ManageIQ#269
but we didn't backport those.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants