-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated outdated dependencies #253
Conversation
hi, @Abdulwahaab710 . |
Done :) |
@moolitayer can you review? (mostly for new dependencies versions implications) |
|
I doubt if they will even notice when that happens... We probably want to enjoy @jrafanie's aetherknight/recursive-open-struct#52 with all the performance work going around, so I would consider dropping support of ruby 2.0 & 2.1 and bumping kubeclient's version. I'm not sure how/if that is problematic to users. @kirs @grosser @albertrdixon care to comment on dropping ruby 2.0, 2.1 support ? |
everything up to 2.1 is unsupported https://www.ruby-lang.org/en/news/2017/04/01/support-of-ruby-2-1-has-ended/ so I'm in favor of getting rid of it ... make the new gem have a |
@moolitayer I doubt that would help most use cases... I would think you would need an enormous recursive structure to see much difference. I could be wrong though. I'm all for dropping unsupported rubies in a non-patch release 👍 |
FYI ROS removal issue #251
…On Thu, Jun 15, 2017 at 2:48 PM, Joe Rafaniello ***@***.***> wrote:
We probably want to enjoy @jrafanie <https://github.com/jrafanie>'s
aetherknight/recursive-open-struct#52
<aetherknight/recursive-open-struct#52> with all
the performance work going around,
@moolitayer <https://github.com/moolitayer> I doubt that would help most
use cases... I would think you would need an enormous recursive structure
to see much difference. I could be wrong though.
I'm all for dropping unsupported rubies in a non-patch release 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#253 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAsZxI_b-HOc-25TphTO8swWru1ekaEks5sEaa_gaJpZM4N6I5->
.
|
👍 for dropping anything < 2.1 |
@Abdulwahaab710 @grosser @moolitayer @jrafanie we may want to change the |
@Abdulwahaab710 if you squash your 2 commits in 1 I think we're good to merge. |
Updated outdated dependencies fixing style for rubocop droping support for ruby 2.0 and 2.1
@@ -1,7 +1,5 @@ | |||
language: ruby | |||
rvm: | |||
- "2.0" | |||
- "2.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simon3z I have removed rvm 2.0 and rvm 2.1
We forgot to update |
Partially cherry-picked from commit d774ff9 + picked style fixes + picked rubocop bump to 0.49.1 - affects default PercentLiteralDelimiters (rubocop/rubocop#4231) - kept other dependencies untouched - kept ruby 2.0, 2.1
Partially cherry-picked from commit d774ff9 + picked style fixes + picked rubocop bump to 0.49.1 - affects default PercentLiteralDelimiters (rubocop/rubocop#4231) - kept other dependencies untouched - kept ruby 2.0, 2.1
Backporting ManageIQ#223 bumped to rubocop with different defaults. These rubocop errors are fixed on master by ManageIQ#253 and ManageIQ#269 but we didn't backport those.
Backporting ManageIQ#223 bumped to rubocop with different defaults. These rubocop errors are fixed on master by ManageIQ#253 and ManageIQ#269 but we didn't backport those.
In this PR I have updated the following outdated dependencies: