Really enforce Config.new(data, nil) prevents external file lookups #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Config.read() is documented to take a file path string. Tests passed a File instance instead. File happened to work too but I'm not goint to guarantee that. All uses of Config.read() on GitHub pass a string.
Promised in README since 040d6ea (ManageIQ#334). Didn't work - absolute path lookups were allowed! Test passed because some of the paths were still relative.
|
@yaacov added comments PTAL |
|
LGTM |
cben
added a commit
to cben/kubeclient
that referenced
this pull request
Dec 9, 2018
…t out Matches Go client's behavior: kubernetes/kubernetes#59495 (comment) Distinguish 3 cases: - absolute (e.g. /path/to/foo) - $PATH-based (e.g. curl) - relative to config file's dir (e.g. ./foo) If base dir explicitly set to nil, refuse to execute external commands, matching existing opt-out from file lookups (ManageIQ#372). Document security aspects of credential plugins.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I promised this in README since version 3.1.1 (#334).
Alas that was a lie — absolute path lookups have always worked 😳
(Test passed because 2 of the 3 paths were still relative, so
File.joinraised an error.)@yaacov @grosser please review