Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update http client version #413

Merged
merged 2 commits into from
Jun 14, 2019
Merged

update http client version #413

merged 2 commits into from
Jun 14, 2019

Conversation

joshlarsen
Copy link
Contributor

I see there is some discussion about changing the http client. In the mean time, perhaps we can bump the current client to a more recent version.

@cben
Copy link
Collaborator

cben commented May 29, 2019

Let's see, reading https://github.com/httprb/http/blob/master/CHANGES.md...

Have you tried running with 4.0?

@cben
Copy link
Collaborator

cben commented May 29, 2019

@joshlarsen
Copy link
Contributor Author

@cben I am running 4.1 and no issues so far. I agree http >= 3.0 seems like a good compromise to support both.

@cben
Copy link
Collaborator

cben commented Jun 2, 2019

  • Simplify setting a timeout httprb/http#446

    The previous style: .timeout(:global|:per_operation, hash_of_options) doesn't work anymore.

    Not a problem, kubeclient only uses http gem for watch and deliberately doesn't set any timeouts.

Other 4.0.0 changes don't sound relevant.

@cben
Copy link
Collaborator

cben commented Jun 3, 2019

Allow `http` `3.*` and `4.*`

Co-Authored-By: Beni Cherniavsky-Paskin <cben@redhat.com>
@cben
Copy link
Collaborator

cben commented Jun 13, 2019

Weird, the 2.2.0 job https://travis-ci.org/abonas/kubeclient/jobs/545301561#L488
said Installing http 4.0.0

@cben
Copy link
Collaborator

cben commented Jun 13, 2019

Aha, 4.0.0 metadata still declared 2.2 support.
Later rubies get Fetching http 4.1.1

cben referenced this pull request in httprb/http Jun 13, 2019
Ruby 2.2 is EOL soon, so no point in having it within supported rubies
for upcoming major 4.x release
@cben
Copy link
Collaborator

cben commented Jun 13, 2019

Asked on httprb/http@190d4eb

@cben cben merged commit a6e8285 into ManageIQ:master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants