Implement usage of nested APIs #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would also yield to fix https://gitlab.com/gitlab-org/gitlab/-/issues/22043 |
|
This is awesome and very important, thanks a lot for tackling this! ❤️
|
|
Thanks for those pointers. I will take a look at that :) |
|
@cben I just force-pushed an amended commit, that includes the tests you asked for. Would you mind reviewing it? :) |
|
Just saw, that rubocop failed. Will fix that real quick |
`handle_uri` expected the Kubernetes API to be rooted at `/` if more than 2 components were included in the provided URL. This was done to extract a potential `api_group` from the URL. This commit changes that behaviour, to parse that `api_group` via a regex, rather than leaning on a strict URL pattern. This commit also takes into account, that OpenShift uses `/oapi`, as well as including a test-suite for that new API URL handling. Tests also include checks for the `@api_group` and `@api_version` instance variables and a non-default version. Implements ManageIQ#318 Fixes ManageIQ#418
cben
approved these changes
Aug 28, 2020
| client = Kubeclient::Client.new('http://localhost:8080/apis/this_is_the_group', 'v1') | ||
| rest_client = client.rest_client | ||
| assert_equal('v1', client.instance_variable_get(:@api_version)) | ||
| assert_equal('this_is_the_group/', client.instance_variable_get(:@api_group)) |
There was a problem hiding this comment.
The trailing slash looked surprising to me, but yep, we had it before and we're sending
hash[:apiVersion] = @api_group + @api_version
so this is good ✔️.
(Also this representation is convenient for automatically handling both foo/v1 and core v1)
|
I'll release this by Sunday. |
cben
added a commit
to cben/kubeclient
that referenced
this pull request
Aug 31, 2020
Implement usage of nested APIs
cben
added a commit
to cben/kubeclient
that referenced
this pull request
Aug 31, 2020
|
Well, for a sufficiently late definition of "Sunday". Released 4.9.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handle_uriexpected the Kubernetes API to be rooted at/if more than 2components were included in the provided URL. This was done to extract a
potential
api_groupfrom the URL.This commit changes that behaviour, to parse that
api_groupvia a regex,rather than leaning on a strict URL pattern.
This commit also takes into account, that OpenShift uses
/oapi, as wellas including a test-suite for that new API URL handling.
Implements #318
Fixes #418