Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow client to retry to avoid common api errors #493

Closed
wants to merge 1 commit into from
Closed

allow client to retry to avoid common api errors #493

wants to merge 1 commit into from

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Mar 5, 2021 •
edited
Loading

/cc @cben

FY some truffle-ruby failures that look unrelated "unknown keyword: status"

uthark
uthark approved these changes Mar 5, 2021
View reviewed changes
Copy link

@uthark uthark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvements.

@grosser grosser mentioned this pull request Mar 5, 2021
Merged
@cben
Copy link
Collaborator

cben commented Mar 6, 2021

Code by itself looks good 👍.
I'll join the discussion of pros/cons on #490.

@cben
Copy link
Collaborator

cben commented Mar 30, 2021

Closing this as I'd merged #490. Thanks again for implementing this alternative.

@cben cben closed this Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uthark uthark uthark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grosser @cben @uthark