Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge Common into kubeclient to simplify setup #497

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Mar 28, 2021

fixes #492 (comment)
@cben

... after this is merged some cleanup to make methods private would be good

@cben
Copy link
Collaborator

cben commented Mar 30, 2021

Thanks! I merged some other PRs so has conflicts now.

@grosser
Copy link
Contributor Author

grosser commented Mar 30, 2021

rebased

@cben
Copy link
Collaborator

cben commented Mar 31, 2021

truffleruby failed:

  1) Failure:
RetryTest#test_watches_for_add [/home/runner/work/kubeclient/kubeclient/test/test_informer.rb:61]:
Expected: ["a", "b"]
  Actual: ["a"]

Sounds like issues you recently fixed #494 (comment)?

@grosser
Copy link
Contributor Author

grosser commented Mar 31, 2021

yeah, I think it's a race condition in the test ... let me restart the test to see if it goes away, can fix the test in another PR

@grosser grosser force-pushed the grosser/mix branch 2 times, most recently from 48ffb67 to 3ddf8af Compare March 31, 2021 15:34
@grosser
Copy link
Contributor Author

grosser commented Mar 31, 2021

... it keeps happening on truffle ruby, but always a different test-case, so skipped informer test for truffle-ruby until I have time to do a more reliable fix for it

@grosser
Copy link
Contributor Author

grosser commented Mar 31, 2021

all good now 👍

@cben cben merged commit deaabd2 into ManageIQ:master Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inline ClientMixin
2 participants