Add Kubeclient#api_valid? #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sure, I can change it to .api_valid? |
Fryguy
force-pushed
the
add_verify_method
branch
from
d4d651e
to
67da601
Compare
Fryguy
force-pushed
the
add_verify_method
branch
from
67da601
to
91cdce0
Compare
|
@abonas Updated to your latest changes and also renamed to api_valid? |
|
I think this Fixes #40 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@abonas Please review. I built this on top of #47, so it includes your commit. If you change anything in there I will have to rebase, but that's ok. So, only need to review the second commit.With Kubeclient having a simple
api_valid?method, then I can call that directly in ManageIQ/manageiq#2156 without any extra logic. Also, that allows you to change the validation method if.apigets unwieldy or is invalid in the future.