-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added automatic inclusion of object kind and api version for create requ... #58
Conversation
@stephenjlevy thanks for the PR. |
@abonas I assumed that the "kind" field was being automatically included since the request knew the entity type, but it wasn't. I was seeing the following error when trying to start a service without specifying "kind": "Service" or the api version.
|
afaik both kind and api version are filled automatically by server side. { It seems that there were other fields that were missing in your example based on the message that you pasted above - name, port, protocol and sessionAffinity. Can you post the example json /how do you construct the service object? |
@stephenjlevy I think I might understand now what you're experiencing, I opened a question regarding it, please see here, lets follow the responses there and based on that see if your PR needs to be merged or not. |
@stephenjlevy , please add a comment in code that those additions are needed till kubernetes/kubernetes#6439 is resolved, and I'll merge the PR. |
Travis is failing on new regular expression checking that was just added to rubocop 0.30.0 (released earlier today). The regex errors are in upstream code, not in code related to this PR. |
@stephenjlevy , I fixed that here: |
e5f660e
to
65d4067
Compare
@abonas I have rebased |
Added automatic inclusion of object kind and api version for create requ...
Can we revert ManageIQ#58? Seems kubernetes/kubernetes#6439 fixed - from which kubernetes version? kubernetes/kubernetes#10200 landed in v1.1.0.
Creating entities was failing because the spec requires the entity kind and apiversion. Added code to automatically include these fields.