Fix AwesomeSpawn spec failures #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommandResult used to take 4 parameters but now takes 5 In the future, we may want to converting over to using "awesome_spawn/spec_helper" and the stub_good_run stuff
|
Checked commit kbrock@2b9d29f with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint spec/yum_spec.rb
|
|
Please also set the minimum version of awesome_spawn to 1.6, since that is the version that introduced this change. That is, if someone has 1.5 and runs these specs, then it will fail in the opposite way. |
agrare
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
👍 good fix, similar to ManageIQ/manageiq-gems-pending#568 and ManageIQ/manageiq-gems-pending#569
Fryguy
added a commit
to Fryguy/linux_admin
that referenced
this pull request
Feb 8, 2024
The change in ManageIQ#238 uses the interface from 1.6, so we need to enforce that as the minimum.
|
I realize I was responsible for the change in the CommandResult parameters. (we should have added it to the end). Sorry |
bdunne
added a commit
that referenced
this pull request
Apr 30, 2024
Breaking Changes: - Bump required_ruby_version to 2.6 & Bump net-ssh for OpenSSL 3.0 support #244 Changed: - Bump ed25519 upper version limit to 2.0 #246 - Bump awesome_spawn minimum to 1.6 #240 - Change redirects to be portable #235 - use PATH to find executable commands #233 Test: - Fix local spec failures on ruby 3.1 #247 - Update paambaati/codeclimate-action action to v6 #245 - Add renovate.json #234 - Update codeclimate channel to the latest in manageiq-style #242 - Test with ruby 3.1 and 3.0 #241 - Fix AwesomeSpawn spec failures #238 - Update actions/checkout version to v4 #237 - Update GitHub Actions versions #236 - update specs to work with recent rspec versions #232 - Add timeout-minutes to setup-ruby job #231 - Switch to GitHub Actions #230 - Remove Hakiri #229 - Fix whitesource config files #228 - Add .whitesource configuration file #227 - Update manageiq-style #226 - drop sudo:false #222 - Switch to manageiq-style #219
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AwesomeSpawn::CommandResult used to take 4 parameters but now takes 5
This was a change in the internal api for awesomespawn
In the future, we may want to converting over to using "awesome_spawn/spec_helper" and the stub_good_run stuff