Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return of orchestration stacks for a service #110

Merged
merged 1 commit into from
Oct 5, 2017
Merged

Fix return of orchestration stacks for a service #110

merged 1 commit into from
Oct 5, 2017

Conversation

jntullo
Copy link

@jntullo jntullo commented Oct 5, 2017

To preface, I have seen this issue before (we had another BZ related to it), and wrote it off to bad data. I do think that changes need to be made to the model to prevent the issue from happening, but for the time being, this will work.

Right now, sometimes services are returning orchestration stacks with nil values in an array, ie [nil]. This is causing the normalizer to fail because it is not expecting a nil object to be passed through. Thought about updating the normalizer, but felt that this was a case that should not happen anyway, and to leave that untouched. Using compact fixes this issue and allows the request to run successfully.

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1496190

@miq-bot add_label bug
@miq-bot assign @abellotti

@miq-bot
Copy link
Member

miq-bot commented Oct 5, 2017

Checked commit jntullo@ec54de6 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@abellotti abellotti added this to the Sprint 71 Ending Oct 16, 2017 milestone Oct 5, 2017
@abellotti
Copy link
Member

Thanks @jntullo every bit helps. 👍

/cc @bzwei something to consider for the model. Thanks.

@abellotti abellotti merged commit b2fdfbd into ManageIQ:master Oct 5, 2017
@bzwei
Copy link
Contributor

bzwei commented Oct 5, 2017

@abellotti Thanks for raising the concern. I will research it when I get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants