Fix return of orchestration stacks for a service #110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To preface, I have seen this issue before (we had another BZ related to it), and wrote it off to bad data. I do think that changes need to be made to the model to prevent the issue from happening, but for the time being, this will work.
Right now, sometimes services are returning orchestration stacks with nil values in an array, ie
[nil]
. This is causing the normalizer to fail because it is not expecting a nil object to be passed through. Thought about updating the normalizer, but felt that this was a case that should not happen anyway, and to leave that untouched. Usingcompact
fixes this issue and allows the request to run successfully.BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1496190
@miq-bot add_label bug
@miq-bot assign @abellotti