Add VM set_description action

[kbrock]

Alternative to #1112

ManageIQ/manageiq#21561

POST /api/vms/:id -d {"action": "set_description", "new_description": "test"}
{
  "success": true,
  "message": "VM id:2 name:'VM_NAME' setting description to test",
  "task_id": "82",
  "task_href": "http://localhost:3000/api/tasks/82",
  "href": "http://localhost:3000/api/vms/2"
}

@agrare sorry. Just had to tweak the way you wrote set_resource_description

[kbrock]

@agrare agreed
As we are standardizing the infrastructure, we are going towards 404.

While I prefer 403, we can not go that direction. Our rbac is on the query so nothing comes back - we can't tell the difference between 403/404.

I have a number of outstanding branches/PRs consolidating code and those move us to towards this 404 consistency

[kbrock]

do we need to tell the user what they passed in, or can we just use the default description of "Setting description for #{model_ident(vm, type)}" (which will get automatically added for us).

[kbrock]

I just rewrote this and realized that this PR already existed

update:

• rebased
• added a few spec lines

[Fryguy]

not sure about this identifier...I'm wondering if vm_edit is better.

[kbrock]

update:

• change privs from vm_rename to vm_edit

[miq-bot]

Checked commit kbrock@f9d6b0c with ruby 2.6.9, rubocop 1.19.1, haml-lint 0.35.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 👍

[jeffibm]

Hey @kbrock, I was trying to use the API like this -

http://localhost:3000/api/vms/2983?action=set_description&new_description=test description

is this the right way?

Also, this is how the component is being rendered.

= react('VmEditForm', {:recordId    => @record.id&.to_s,
                         :emsId       => @record.ems_id&.to_s,
                         :showTitle   => !@edit[:explorer],
                         :isTemplate  => @record.kind_of?(::MiqTemplate),
                         :displayName => model_for_vm(@record).display_name})

we have 2 kinds of id in here,

1. @record.id (ManageIQ::Providers::redhat-new::InfraManager::Vm) and
2. @record.ems_id

I am guessing we need to use the @record.id in the API post request.

[kbrock]

Hey Jeffrey,

Use @record.id.
The rest looks good to me.

From here, the actual description will not change but rather a message will get sent to the provider to change it at the source.

Think you'll get a task I'd, and when the task completes, it will tell you success but in fact the success is the queuing to the provider.

If you have a provider setup, then it will flow back, otherwise you won't be able to test it on your machine.

[kbrock]

@jeffibm Think the issue is this needs to be a POST and not a GET

http://localhost:3000/api/vms/2983?action=set_description&new_description=test description
(where 2983 is @record.id)