-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Resource Pool API to include type attribute #1248
Update Resource Pool API to include type attribute #1248
Conversation
The query returns only the resource pools associated with cloud management when the
|
a3b7e32
to
c7e65fe
Compare
Checked commit Guddetisandeep@c7e65fe with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint app/controllers/api/resource_pools_controller.rb
|
@Guddetisandeep - We found there's a better way to do this than using a type filter. Instead, the caller can pass a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can close this PR, and the callers can use collection_class
instead, which should already work for ResourcePools.
Closing this PR using |
Dependent PR for enabling Resource Pool feature under Clouds section(Compute > Clouds > Resource Pools)
manageiq Core changes
Update Resource Pool Identifiers and UI for Cloud and Infrastructure Categorization manageiq#22879
manageiq-ui-classic changes
Add Resource Pool UI for Cloud managers manageiq-ui-classic#8929
manageiq-schema changes
Update resource pool feature identifiers to infrastructure-specific manageiq-schema#718
manageiq-api changes
Update Resource Pool API to include type attribute #1248