Use pluggable credential types method call #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
nasark
force-pushed
the
pluggable_credential_type_options
branch
from
f831148
to
968f4c0
Compare
nasark
commented
Apr 17, 2024
Comment on lines
+482
to
486
| if defined? klass::API_OPTIONS | ||
| klass::API_OPTIONS.tap do |options| | ||
| options[:attributes].each do |_k, val| | ||
| val[:type] = val[:type].to_s if val && val[:type] | ||
| end |
There was a problem hiding this comment.
This was needed in the specs because the nested hashes in the response contain string keys
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Apr 17, 2024
From Pull Request: ManageIQ/manageiq-api#1259
|
Checked commit nasark@968f4c0 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint spec/requests/authentications_spec.rb
|
agrare
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally credential types were hard coded in the
Authenticationclass. With this change we can define credential types in the respective classes and then pull the info for the OPTIONS call from the newAuthentications.credential_typesmethodNeeded for:
@miq-bot assign @agrare
@miq-bot add_reviewer @agrare
@miq-bot add_labels enhancement