Return picture href for generic objects subcollections

[jntullo]

This enhancement automatically returns the picture href if the picture attribute is specified for generic objects.

Example Usage

GET /api/services/10r1?expand=generic_objects&attributes=generic_objects.picture

@miq-bot add_label enhancement
@miq-bot assign @abellotti

cc: @chalettu

[chalettu]

@jntullo this is great. Can you show an example of the output? The output we were seeing last week didn't include the pictures file extension and the correct path.

[miq-bot]

Checked commit jntullo@7395fed with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

[jntullo]

@chalettu

{  
   "href":"http://localhost:3000/api/services/10000000000645",
   "id":"10000000000645",
   "name":"Jillian's Azure Service",
   "description":"Azure",
   "guid":"6ce8f6c2-7f93-4a7e-b618-da9acab470ac",
   "options":{  

   },
   "display":false,
   "created_at":"2017-08-07T16:52:46Z",
   "updated_at":"2017-08-07T16:52:46Z",
   "miq_group_id":"10000000000001",
   "retired":false,
   "tenant_id":"10000000000001",
   "initiator":"user",
   "generic_objects":[  
      {  
         "href":"http://localhost:3000/api/services/10000000000645/generic_objects/10000000000001",
         "id":"10000000000001",
         "name":"GO 2",
         "generic_object_definition_id":"10000000000001",
         "created_at":"2017-08-15T17:35:08Z",
         "updated_at":"2017-09-07T12:05:14Z",
         "properties":{  
            "vms":[  
               10000000000615
            ],
            "start":true
         },
         "picture":{  
            "href":"http://localhost:3000/api/picture/10000000000001",
            "id":"10000000000001",
            "resource_id":"10000000000001",
            "resource_type":"GenericObjectDefinition",
            "image_href":"http://localhost:3000/pictures/10r1.png",
            "extension":"png"
         }
      }
   ],
   "actions"   {  
      ...
   }
}

[chalettu]

That looks perfect. Great addition

[abellotti]

@jntullo I wonder if the above change will cause expectation that we always return that attr even if just querying pictures. Do you think we should add image_href to additional_attributes for picture resources ?

Doesn't need to be changed here, just something to think about, could be follow-up PR.

[jntullo]

@abellotti was just putting that together, actually 😆 👍 (separate PR)

[abellotti]

btw, is this still needed if the other PR #127 gets merged ?

[jntullo]

@abellotti yes it is