Add decorator for VNC Console #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SUI requires a check on VNC console because the existing decorators lead to a false positive about console enablement for VMWare consoles.
|
@miq-bot assign @abellotti |
|
Checked commit jntullo@57943ce with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@jntullo is this PR really fine/yes ? shouldn't that be in a different repo ? |
|
@simaishi this needs to be back-ported to Fine via ManageIQ/manageiq#16382. Thanks. |
|
LGTM!! Thanks @jntullo for fixing this. 👍 |
simaishi
pushed a commit
that referenced
this pull request
Nov 6, 2017
Add decorator for VNC Console (cherry picked from commit 9957510) https://bugzilla.redhat.com/show_bug.cgi?id=1510131
|
Gaprindashvili backport details: |
|
Backported to Euwe via ManageIQ/manageiq#16377 |
|
Backported to Fine via ManageIQ/manageiq#16382 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUI requires a check on VNC console because the existing decorators lead to a false positive about console enablement for VMWare consoles.
@miq-bot add_label bug, gaprindashvili/yes, fine/yes
cc: @AllenBW