Don't respond with 400 on ArgumentError #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an `ArgumentError` was raised it means that we either did something wrong or we did not handle the request properly and we should respond approriately with a 500.
|
From @mkanoor : "for AutomateWorkspaces if we got an ID instead of a GUID I wanted to raise an Argument Error" We need to get something from automate to be able to respond accordingly for this (even if it's just... rescuing |
abellotti
reviewed
Nov 2, 2017
| @@ -1,6 +1,7 @@ | |||
| module Api | |||
| class AutomateWorkspacesController < BaseController | |||
| def edit_resource(type, id, data = {}) | |||
| raise BadRequestError, "must contain at least one attribute to edit" if data.blank? | |||
There was a problem hiding this comment.
@mkanoor is this the only case from the model that was raising the ArgumentError ?
|
Checked commit imtayadeway@5b6a866 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
👍 |
|
one last question Gaprindashvili/yes ? |
|
@abellotti sorry! Forgot to add. I consider this a bug, so adding Gaprindashvili/yes |
|
Thanks @imtayadeway. 👍 |
simaishi
pushed a commit
that referenced
this pull request
Nov 6, 2017
…quest Don't respond with 400 on ArgumentError (cherry picked from commit efe7610)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an
ArgumentErrorwas raised it means that we either did somethingwrong or we did not handle the request properly and we should respond
approriately with a 500.
@miq-bot add-label bug
@miq-bot assign @abellotti