Adding support for /api/container_groups #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is not mergeable. Please rebase and repush. |
abellotti
force-pushed
the
container_groups
branch
from
d6252cc to
3d73be3
Compare
abellotti
changed the title
|
ping @jntullo |
- New collection - Support GETs and bulk query - Support custom_actions - Specs added
abellotti
force-pushed
the
container_groups
branch
from
3d73be3 to
592efd5
Compare
|
Checked commit abellotti@592efd5 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
gtanzillo
approved these changes
Nov 21, 2017
|
Ping @gmcculloug this needs to go to 5.9.1, before I flip the g/yes switch does anything need to go in the model ? More specifically, the custom button support for container_groups comes to mind which was not meant for the G-release. Thanks. /cc @jntullo @Loicavenel |
|
cc: @bascar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1549658