Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for /api/container_images #185

Merged
merged 2 commits into from
Nov 21, 2017

Conversation

abellotti
Copy link
Member

@abellotti abellotti commented Nov 8, 2017

  • New collection
  • Support GETs
  • Specs added

@miq-bot
Copy link
Member

miq-bot commented Nov 17, 2017

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Nov 20, 2017

This pull request is not mergeable. Please rebase and repush.

@abellotti abellotti changed the title [WIP] Adding support for /api/container_images Adding support for /api/container_images Nov 21, 2017
@abellotti abellotti removed the wip label Nov 21, 2017
@abellotti
Copy link
Member Author

ping @jntullo

@miq-bot
Copy link
Member

miq-bot commented Nov 21, 2017

This pull request is not mergeable. Please rebase and repush.

Copy link

@jntullo jntullo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

- New collection
- Support GETs and bulk query
- Support custom_actions
- Specs added
- API does not currently support guid as virtual attributes
@miq-bot
Copy link
Member

miq-bot commented Nov 21, 2017

Checked commits abellotti/manageiq-api@9180bfd~...835fdfc with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 0 offenses detected
Everything looks fine. ⭐

@abellotti abellotti added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 21, 2017
@gtanzillo gtanzillo merged commit 627fd30 into ManageIQ:master Nov 21, 2017
@abellotti abellotti deleted the container_images branch November 22, 2017 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants