Use destroy_queue for provider delete #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @durandom |
zeari
reviewed
Nov 20, 2017
| raise BadRequestError, "Must specify an id for deleting a #{type} resource" unless id | ||
| provider = resource_search(id, type, collection_class(type)) | ||
| task = provider.class.schedule_destroy_queue(provider.id) | ||
| action_result(true, "#{provider_ident(provider)} deleting", :task_id => task.id) |
There was a problem hiding this comment.
I think you should use destroy_queue instead of schedule_destroy_queue because it also schedules the destroy of child managers
jntullo
changed the title
|
@miq-bot assign @abellotti |
Changes to ExtManagementSystem now require the use of destroy_queue to queue the deletion of the provider. Without this change, provider deletion is silently failing due to a before_hook on destroy that checks if there are any active queues for the provider. The orchestrate_delete method that will now be called will resolve this. https://bugzilla.redhat.com/show_bug.cgi?id=1501941
|
Checked commit jntullo@e91c02a with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
abellotti
reviewed
Nov 20, 2017
| raise BadRequestError, "Must specify an id for deleting a #{type} resource" unless id | ||
| provider = resource_search(id, type, collection_class(type)) | ||
| task = provider.destroy_queue | ||
| action_result(true, "#{provider_ident(provider)} deleting", :task_id => task.id, :parent_id => id) |
There was a problem hiding this comment.
why the parent_id here ? that's different behavior than the old destroy_provider method.
There was a problem hiding this comment.
@abellotti yeah, I'm confused as to how it was returning the href, because unless the parent_id is specified, it wasn't.
simaishi
pushed a commit
that referenced
this pull request
Nov 20, 2017
Use destroy_queue for provider delete (cherry picked from commit 4d00d26) https://bugzilla.redhat.com/show_bug.cgi?id=1515449
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to ExtManagementSystem now require the use of schedule_destroy_queue to queue the deletion of the provider. Without this change, provider deletion is silently failing due to a before_hook on destroy that checks if there are any active queues for the provider. The orchestrate_delete method that will now be called will resolve this.
https://bugzilla.redhat.com/show_bug.cgi?id=1501941
@miq-bot add_label bug, gaprindashvili/yes, blocker
cc: @gtanzillo @zeari