-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating PhysicalChassis controller and adding endpoint configuration #362
Creating PhysicalChassis controller and adding endpoint configuration #362
Conversation
without this PR you can still access them as a relationship, i.e. GET /api/providers/:id?attributes=physical_chassis. Is the /api/physical_chassis or formal subcollection i.e. GET /api/providers/:id/physical_chassis needed ? If so you'd need an miq product feature identifier for it (manageiq/db/fixtures/miq_product_features.yml) so we can specify the :identifier: entries in the api.yml accordingly (RBAC purposes). Thanks. |
@abellotti Thank you for the reminder. I put all the necessary identifiers in api.yml and miq_product_features.yml for both GET and POST features. |
ping @EsdrasVP can you revisit ? looks like the dependent PRs were merged. |
71f9c11
to
4d84ea6
Compare
4d84ea6
to
f68f282
Compare
f68f282
to
ddbbc82
Compare
Checked commits EsdrasVP/manageiq-api@d139c72~...ddbbc82 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 app/controllers/api/physical_chassis_controller.rb
|
@abellotti I revised and now both code climate and travis are passing. |
Thanks @EsdrasVP for the API Enhancement. LGTM !! 👍 |
This PR adds:
Depends on:
ManageIQ/manageiq#17320 [Merged]
ManageIQ/manageiq-api#364 [Merged]