Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating PhysicalChassis controller and adding endpoint configuration #362

Merged
merged 2 commits into from
May 21, 2018

Conversation

EsdrasVP
Copy link
Member

@EsdrasVP EsdrasVP commented Apr 20, 2018

This PR adds:

  • GET /api/physical_chassis
  • GET /api/physical_chassis/:id
  • POST /api/physical_chassis (action: refresh)
  • POST /api/physical_chassis/:id (action: refresh)

Depends on:
ManageIQ/manageiq#17320 [Merged]
ManageIQ/manageiq-api#364 [Merged]

@EsdrasVP EsdrasVP changed the title Creating PhysicalChassis controller and adding endpoint configuration [WIP] Creating PhysicalChassis controller and adding endpoint configuration Apr 20, 2018
@miq-bot miq-bot added the wip label Apr 20, 2018
@abellotti
Copy link
Member

without this PR you can still access them as a relationship, i.e. GET /api/providers/:id?attributes=physical_chassis. Is the /api/physical_chassis or formal subcollection i.e. GET /api/providers/:id/physical_chassis needed ? If so you'd need an miq product feature identifier for it (manageiq/db/fixtures/miq_product_features.yml) so we can specify the :identifier: entries in the api.yml accordingly (RBAC purposes). Thanks.

@EsdrasVP
Copy link
Member Author

@abellotti Thank you for the reminder. I put all the necessary identifiers in api.yml and miq_product_features.yml for both GET and POST features.

@EsdrasVP EsdrasVP changed the title [WIP] Creating PhysicalChassis controller and adding endpoint configuration Creating PhysicalChassis controller and adding endpoint configuration Apr 23, 2018
@miq-bot miq-bot removed the wip label Apr 23, 2018
@abellotti
Copy link
Member

ping @EsdrasVP can you revisit ? looks like the dependent PRs were merged.

@EsdrasVP EsdrasVP force-pushed the enable_chassis_api_endpoint branch from 71f9c11 to 4d84ea6 Compare May 14, 2018 20:54
@EsdrasVP EsdrasVP changed the title Creating PhysicalChassis controller and adding endpoint configuration [WIP] Creating PhysicalChassis controller and adding endpoint configuration May 15, 2018
@miq-bot miq-bot added the wip label May 15, 2018
@EsdrasVP EsdrasVP force-pushed the enable_chassis_api_endpoint branch from 4d84ea6 to f68f282 Compare May 15, 2018 14:05
@EsdrasVP EsdrasVP force-pushed the enable_chassis_api_endpoint branch from f68f282 to ddbbc82 Compare May 15, 2018 14:12
@miq-bot
Copy link
Member

miq-bot commented May 15, 2018

Checked commits EsdrasVP/manageiq-api@d139c72~...ddbbc82 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

app/controllers/api/physical_chassis_controller.rb

@EsdrasVP EsdrasVP changed the title [WIP] Creating PhysicalChassis controller and adding endpoint configuration Creating PhysicalChassis controller and adding endpoint configuration May 15, 2018
@miq-bot miq-bot removed the wip label May 15, 2018
@EsdrasVP
Copy link
Member Author

@abellotti I revised and now both code climate and travis are passing.

@abellotti abellotti self-assigned this May 21, 2018
@abellotti abellotti added this to the Sprint 86 Ending May 21, 2018 milestone May 21, 2018
@abellotti
Copy link
Member

Thanks @EsdrasVP for the API Enhancement. LGTM !! 👍

@abellotti abellotti merged commit 14d4f0e into ManageIQ:master May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants