Rename dialog_edit and dialog_new to *_editor #395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label gaprindashvili/no |
The `dialog_edit` and `dialog_new` features were removed in ManageIQ/manageiq#17550. The new features to do the same thing seem to be called `dialog_new_editor` and `dialog_edit_editor` - renaming.
|
Checked commit https://github.com/himdel/manageiq-api/commit/38c8aa1aa466418dae497fa0daa9de07cd53a412 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Well, it looks good to me but I'm a little bit afraid that I broke the API by deleting those unused UI features 😭 so I think this is fully @abellotti's call. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dialog_editanddialog_newfeatures were removed in ManageIQ/manageiq#17550.The new features to do the same thing seem to be called
dialog_new_editoranddialog_edit_editor- renaming.Cc @skateman , @abellotti