Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ordering ServiceTemplates with a schedule_time #400

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Allow ordering ServiceTemplates with a schedule_time #400

merged 1 commit into from
Jun 21, 2018

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Jun 15, 2018 •
edited by simaishi
Loading

Depends on: ManageIQ/manageiq#17594

@AllenBW With this change, you can order now or schedule with { :action => "order", :schedule_time => "2018-06-15 21:26:43 UTC" }

https://bugzilla.redhat.com/show_bug.cgi?id=1564255

@AllenBW AllenBW mentioned this pull request Jun 15, 2018
Merged
@AllenBW
Copy link
Member

AllenBW commented Jun 15, 2018

@bdunne yer a :godmode: 🙇‍♀️ 🏩 HAVE A GREAT VACAY

@miq-bot
Copy link
Member

miq-bot commented Jun 15, 2018

Checked commit bdunne@b115f02 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 0 offenses detected
Everything looks fine. 🏆

@AllenBW AllenBW mentioned this pull request Jun 19, 2018
Merged
@AllenBW
Copy link
Member

AllenBW commented Jun 19, 2018

This will also need to be backported Gaprindashvili

@AllenBW
Copy link
Member

AllenBW commented Jun 21, 2018

@abellotti WOOOOOOOOH GOOD NEWS #17594 was merged! Could yah give this a quick 👁 ?

@abellotti abellotti self-assigned this Jun 21, 2018
@abellotti
Copy link
Member

Thanks @bdunne for the API Enhancement. LGTM!! 👍

@abellotti abellotti merged commit bc9cae5 into ManageIQ:master Jun 21, 2018
@abellotti abellotti added this to the Sprint 89 Ending Jul 2, 2018 milestone Jun 21, 2018
@bdunne bdunne deleted the order_service_template branch July 3, 2018 16:04
@bdunne
Copy link
Member Author

bdunne commented Jul 5, 2018

@miq-bot add_label gaprindashvili/yes

@bdunne
Copy link
Member Author

bdunne commented Jul 5, 2018

https://bugzilla.redhat.com/show_bug.cgi?id=1564255

simaishi pushed a commit that referenced this pull request Jul 31, 2018
@abellotti @simaishi
Merge pull request #400 from bdunne/order_service_template
2c95b3d 
Allow ordering ServiceTemplates with a schedule_time
(cherry picked from commit bc9cae5)

https://bugzilla.redhat.com/show_bug.cgi?id=1608351
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 2c95b3d56e400586ba56b2758c4ee4d810d44d16
Author: Alberto Bellotti <abellotti@users.noreply.github.com>
Date:   Thu Jun 21 09:51:37 2018 -0400

    Merge pull request #400 from bdunne/order_service_template
    
    Allow ordering ServiceTemplates with a schedule_time
    (cherry picked from commit bc9cae59eaa0ec82677ffd93e99a30abb0a48ae5)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1608351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abellotti abellotti abellotti approved these changes

Assignees

@abellotti abellotti

Labels
blocker enhancement gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bdunne @AllenBW @miq-bot @abellotti @simaishi