Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags Subcollection on Generic Objects #64

Merged
merged 1 commit into from
Sep 21, 2017
Merged

Tags Subcollection on Generic Objects #64

merged 1 commit into from
Sep 21, 2017

Conversation

jntullo
Copy link

@jntullo jntullo commented Sep 20, 2017

This allows for retrieval, assigning, and un-assigning of tags on Generic Objects

Usage

POST /api/generic_objects/:id/tags

  • Can assign tags as follows:
{
  'action': 'assign',
  'category': 'department',
  'name': 'finance'
}
  • Can unassign tags as follows:
{
  'action': 'unassign',
  'category': 'department',
  'name': 'finance'
}

GET /api/generic_objects/:id/tags

  • Returns all assigned tags on a generic object

@miq-bot add_label enhancement
@miq-bot assign @abellotti

cc: @chalettu

@abellotti abellotti self-assigned this Sep 20, 2017
@abellotti
Copy link
Member

Hi @jntullo, what about tag_collections_spec.rb ? I thought we added specs there everything we expose the tags subcollection to a new collection.

@jntullo
Copy link
Author

jntullo commented Sep 21, 2017

@abellotti moved them 👍

@miq-bot
Copy link
Member

miq-bot commented Sep 21, 2017

Checked commit jntullo@ddd4618 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@abellotti
Copy link
Member

Thanks @jntullo for the enhancement. 😍

@abellotti abellotti merged commit c83fca7 into ManageIQ:master Sep 21, 2017
@abellotti abellotti added this to the Sprint 70 Ending Oct 2, 2017 milestone Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants