Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VMs subcollection to providers #66

Merged
merged 1 commit into from
Sep 22, 2017
Merged

Add VMs subcollection to providers #66

merged 1 commit into from
Sep 22, 2017

Conversation

jntullo
Copy link

@jntullo jntullo commented Sep 22, 2017

Example usage

/api/providers/:id/vms

  • returns the VMs on a provider
{
  "name"      : "vms",
  ...
  "resources" : [
    {"href" : "/api/providers/:p_id/vms/:vm_id"}
  ]
}

/api/providers?expand=resources,vms

  • It can expand vms on all providers
{
  "name"      : "providers",
  "resources" : [
    {
      "href" : "/api/providers/:id",
      ...
      "vms"  : [
       {  "href" : "/api/providers/:id/vms/:id", "name" : "vm name" ... } 
      ]
    }
  ]
}

@miq-bot add_label enhancement
@miq-bot assign @abellotti
cc: @zhitongLBN

@miq-bot
Copy link
Member

miq-bot commented Sep 22, 2017

Checked commit jntullo@5c8eafe with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@abellotti abellotti self-assigned this Sep 22, 2017
@abellotti abellotti added this to the Sprint 70 Ending Oct 2, 2017 milestone Sep 22, 2017
@abellotti
Copy link
Member

Short and sweet, thanks @jntullo for this enhancement !! 👍

@abellotti abellotti merged commit 49f17d8 into ManageIQ:master Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants