Added support for collection specific hide_resources option. #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for the new automate_workspaces collection where we don't want to return current set of workspaces as they are only accessible by resource guid from automate. We're leveraging the current mechanism we have in place for the hide=resources parameter and supported at the collection level via the api.yml. We've contemplated the 404 on the collection but that breaks the clients and inhibits it from getting collection level actions and such.
|
Checked commit abellotti@cd6a932 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
mkanoor
approved these changes
Sep 27, 2017
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for the new automate_workspaces collection where
we don't want to return current set of workspaces as they
are only accessible by resource guid from automate.
We're leveraging the current mechanism we have in place for
the hide=resources parameter and supported at the collection
level via the api.yml.
We've contemplated the 404 on the collection but that breaks
the clients and inhibits it from getting collection level
actions and such.