add ability to set custom attributes on services via api #85
Conversation
|
api.yml declaration (identifiers for the subcollection actions, see vms/instances/providers for example), also, the specs would be needed, also look at instances for reference. Thanks!! |
|
@abellotti Hi, should we do similar spec instances_spec.rb and services_spec.rb for custom attributes. Or, since they're almost the same, test for custom_attributes mixin. Thanks! |
ailisp
force-pushed
the
services-api-custom-attr
branch
2 times, most recently
from
865f08b
to
ef1cb3e
Compare
ailisp
force-pushed
the
services-api-custom-attr
branch
from
1782c2d
to
9cf815e
Compare
|
@miq-bot remove-label wip |
miq-bot
changed the title
|
This pull request is not mergeable. Please rebase and repush. |
|
Checked commits ailisp/manageiq-api@c4f74c0~...07049fd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Thanks @ailisp for the API Enhancement !! 👍 The Hakiri warning above is unrelated and was taken care in a separate PR so I'll go ahead and merge. |
Issue: missing ability to set custom attributes on services via api, which is now fixed
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1481547
\cc @abellotti @gtanzillo
@miq-bot add-label wip, bug