Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .ansible.cfg for ansible-playbook #196

Merged
merged 1 commit into from
Jul 2, 2018

Conversation

simaishi
Copy link
Contributor

@miq-bot
Copy link
Member

miq-bot commented Jun 15, 2018

Checked commit simaishi@6bc8816 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

Copy link

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@carbonin carbonin self-assigned this Jul 2, 2018
@carbonin carbonin merged commit 4530c62 into ManageIQ:master Jul 2, 2018
@carbonin carbonin added this to the Sprint 89 Ending Jul 2, 2018 milestone Jul 2, 2018
@simaishi simaishi deleted the add_ansible_cfg branch July 2, 2018 16:53
@carbonin
Copy link
Member

@simaishi @Ladas Looks like this is breaking embedded ansible.
https://bugzilla.redhat.com/show_bug.cgi?id=1600048

Just running ansible-playbook on an appliance with this change causes:

[root@localhost ~]# ansible-playbook
Error reading config file (/root/.ansible.cfg): File contains no section headers.
file: /root/.ansible.cfg, line: 1
'stdout_callback = json\n'

Looks like adding a [default] section to the file fixes the issue. Was that the intention here?

@Ladas
Copy link

Ladas commented Jul 11, 2018

@carbonin interesting, it works for me. So I think we can theoretically revert this, since this is only valid for ansible-playbook. For ansible-runner they've added parameter ansible-runner ... --json and this cfg is not being used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants