Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to GitHub Actions #178

Merged
merged 6 commits into from
Mar 21, 2023
Merged

Switch to GitHub Actions #178

merged 6 commits into from
Mar 21, 2023

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Feb 15, 2022

CI: https://github.com/Fryguy/manageiq-appliance_console/actions?query=branch%3Agithub_actions

To replicate the tty issues locally, run the tests with:

true | bundle exec rspec 2>&1 | cat

@Fryguy
Copy link
Member Author

Fryguy commented Apr 1, 2022

This one is going to be tough, because of the postgres-specific tests.

@Fryguy
Copy link
Member Author

Fryguy commented Apr 1, 2022

Postponing my work on this one...I think I mostly got the TTY problems fixed, through there's still a couple that don't seem to be honoring the newline .raw! thing.

The database backup/restore is gonna need a complete overhaul I think, which I don't want to spend time on at the moment.

Rakefile Outdated
end
# task :default do
# Rake::Task["spec#{':ci' if ENV['CI']}"].invoke
# end
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a hack to avoid the postgres tests and we should undo this.

@miq-bot
Copy link
Member

miq-bot commented Feb 27, 2023

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@Fryguy Fryguy changed the title [WIP] Switch to GitHub Actions Switch to GitHub Actions Mar 21, 2023
@miq-bot
Copy link
Member

miq-bot commented Mar 21, 2023

Checked commits Fryguy/manageiq-appliance_console@b6198dc~...48d0f9f with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
4 files checked, 2 offenses detected

spec/spec_helper.rb

@miq-bot miq-bot removed the wip label Mar 21, 2023
@kbrock kbrock merged commit df5cffb into ManageIQ:master Mar 21, 2023
kbrock added a commit to kbrock/manageiq-appliance_console that referenced this pull request Mar 21, 2023
this was necessary to get older version of highline up and running in rails
see ManageIQ#178 df5cffb
kbrock added a commit to kbrock/manageiq-appliance_console that referenced this pull request Mar 21, 2023
this was necessary to get older version of highline up and running in rails
see ManageIQ#178 df5cffb
@Fryguy Fryguy deleted the github_actions branch May 3, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants