Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] highline-3 #212

Closed
wants to merge 1 commit into from
Closed

[WIP] highline-3 #212

wants to merge 1 commit into from

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented May 2, 2023

testing with highline 3.0.0

@miq-bot
Copy link
Member

miq-bot commented Aug 7, 2023

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@kbrock
Copy link
Member Author

kbrock commented Aug 7, 2023

Looks like highline still has not released 3.0
Leaving as WIP, and looking forward to a stale ping in 3 months to revisit.

@miq-bot
Copy link
Member

miq-bot commented Dec 25, 2023

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@miq-bot
Copy link
Member

miq-bot commented Feb 7, 2024

Checked commit kbrock@247c438 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@kbrock
Copy link
Member Author

kbrock commented Feb 8, 2024

Looks like the results are not quite the same thing

WIP: fix test failures related to what is displayed on stdout

looks like highline converted from readline to reline. we may want to revisit how we setup our tests

@miq-bot
Copy link
Member

miq-bot commented May 1, 2024

This pull request is not mergeable. Please rebase and repush.

@kbrock
Copy link
Member Author

kbrock commented May 1, 2024

I could have sworn this was working but it looks like quite a bit of work.
We can upgrade this at a later time

@kbrock kbrock closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants