CP4AIOPS-3113 Store saml remote user configuration separately from sssd lookup #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
kbrock
force-pushed
the
CP4AIOPS-3113
branch
4 times, most recently
from
874832a
to
b6bbda2
Compare
Fryguy
reviewed
Sep 4, 2024
Comment on lines
105
to
100
| # legacy systems may still have it stored as the old name | ||
| remove_file(HTTPD_CONFIG_DIRECTORY.join("manageiq-remote-user.conf")) |
There was a problem hiding this comment.
Let's change this comment to be only on the line it comments on. Otherwise it appears like it applies to the whole "paragraph" of code.
Suggested change
| # legacy systems may still have it stored as the old name | |
| remove_file(HTTPD_CONFIG_DIRECTORY.join("manageiq-remote-user.conf")) | |
| remove_file(HTTPD_CONFIG_DIRECTORY.join("manageiq-remote-user.conf")) # legacy systems may still have it stored as the old name |
There was a problem hiding this comment.
thnx.
think we're getting away from same line comments (rubocop)
Will change wording to make more clear
There was a problem hiding this comment.
I disagree with rubocop on that :)
Fryguy
reviewed
Sep 4, 2024
| @@ -1,5 +1,5 @@ | |||
| module ManageIQ | |||
| module ApplianceConsole | |||
| VERSION = '9.1.1'.freeze | |||
| VERSION = '9.2'.freeze | |||
There was a problem hiding this comment.
Suggested change
| VERSION = '9.2'.freeze | |
| VERSION = '9.2.0'.freeze |
kbrock
force-pushed
the
CP4AIOPS-3113
branch
from
b6bbda2
to
16eee3d
Compare
Fryguy
reviewed
Sep 4, 2024
| @@ -1,5 +1,5 @@ | |||
| module ManageIQ | |||
| module ApplianceConsole | |||
| VERSION = '9.1.1'.freeze | |||
| VERSION = '10.0'.freeze | |||
There was a problem hiding this comment.
Suggested change
| VERSION = '10.0'.freeze | |
| VERSION = '10.0.0'.freeze |
saml configuration (mod_auth_mellon) uses a different delimiter from sssd type configurations. The templates have been changed to reflect this change. The appliance console is now respecting this change
kbrock
force-pushed
the
CP4AIOPS-3113
branch
from
16eee3d
to
f438373
Compare
|
update:
update:
update:
|
|
Checked commit kbrock@f438373 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
Fryguy
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of ManageIQ/manageiq#23139
saml configuration (mod_auth_mellon) uses a different delimiter from sssd type configurations.
The templates have been changed to reflect this change. The appliance console is now respecting this change